Add NIO write operations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 7, 2023 08:56
* added the crt library for the s3 transfermanager * added S3WritableByteChannel and enabled the basic test case * changed the async s3 client to use the crt builder
|
@markjschreiber could you have a look at this? |
| @@ -260,11 +260,8 @@ private S3AsyncClient asyncClientForRegion(String regionString){ | |||
| Region region = regionString.equals("") ? Region.US_EAST_1 : Region.of(regionString); | |||
| logger.debug("bucket region is: '{}'", region.id()); | |||
|
|
|||
| return S3AsyncClient.builder() | |||
| return S3AsyncClient.crtBuilder() | |||
src/main/java/software/amazon/nio/spi/s3/S3SeekableByteChannel.java
Outdated
Show resolved
Hide resolved
markjschreiber
requested changes
Feb 14, 2023
src/main/java/software/amazon/nio/spi/s3/S3WritableByteChannel.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/nio/spi/s3/S3WritableByteChannel.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/nio/spi/s3/S3WritableByteChannel.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/nio/spi/s3/S3FileSystemProviderTest.java
Outdated
Show resolved
Hide resolved
|
@markjschreiber thank you for the comments. I will have a look at them today |
|
Don't forget to include updated information in the README about how write works and what users should expect. |
|
Yes, I will do this. I just wanted to do the timeout beforehand and update the README as last step. |
added 3 commits
February 16, 2023 09:42
… order to focus the test on the channel collection handling
… as the read and write channel and adapted tests
markjschreiber
approved these changes
Feb 23, 2023
|
@oeph, many thanks for the contribution! |
markjschreiber
pushed a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #4
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.