Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependencies and Duplicated Code #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kyleyost19
Copy link

Issue #, if available:
The last comment on #22 is relevant

Description of changes:

  • Remove vendor folder as it should not be included for libraries without a package main
  • Remove all "adapters" as they are not needed. Each router that is supported implements http.Handler, so there is no need to couple this project with those routers. Let the users of this library choose what router and version they want to use.
  • Simply renamed the httpadapter package to proxy and everything else is left in tact. Obviously this is a breaking change, but I left all the other code as unchanged as possible

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant