Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multi-client support #398

Merged
merged 17 commits into from
May 14, 2019

Conversation

manueliglesias
Copy link
Contributor

Issue #, if available:

Description of changes:
This PR adds support for having multiple instances of the AWSAppSyncClient with offlineSupport enabled.

If using more than one client instance, a keyPrefix is mandatory for offline support and items in the persisted store will have that prefix.

Also, this PR adds:

  • Upgrade Jest
  • Increase test coverage
  • Improve TypeScript definitions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🥇
I addressed a few non blocking comments.

packages/aws-appsync/__tests__/client.ts Show resolved Hide resolved
packages/aws-appsync/__tests__/client.ts Outdated Show resolved Hide resolved
packages/aws-appsync/src/client.ts Show resolved Hide resolved
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @manueliglesias 🥇

@manueliglesias manueliglesias merged commit 1885a8a into awslabs:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants