Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(offline): Call observer.error when discarding mutation #408

Merged
merged 1 commit into from
May 31, 2019

Conversation

manueliglesias
Copy link
Contributor

Fixes: aws-amplify/amplify-js#3243

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@manueliglesias manueliglesias marked this pull request as ready for review May 28, 2019 17:38
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍

@elorzafe elorzafe merged commit 526b9b8 into awslabs:master May 31, 2019
@elliott-king
Copy link

Just jumping in to say I did test this with my issue & it has resolved the silent failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3Object upload failing silently - not even a POST request.
3 participants