Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update changelog for v1.1.5 #381

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

aaronchung-bitquill
Copy link
Contributor

Summary

Description

Additional Reviewers

@karenc-bq @joyc-bq @sergiyv-improving @aaron-congo @brunos-bq

Copy link
Contributor

@hsuamz hsuamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we group the README.md changes? I would suggest we lead with the actual driver changes first and then the documentation changes after in this section.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@aaronchung-bitquill aaronchung-bitquill force-pushed the changelog-1.1.5 branch 2 times, most recently from a78d2fa to 7a59409 Compare March 29, 2023 23:17
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@aaronchung-bitquill aaronchung-bitquill force-pushed the changelog-1.1.5 branch 2 times, most recently from e6fe8ae to 6b3d8bb Compare March 30, 2023 18:18
CHANGELOG.md Outdated
### Changed

* Optimized thread locks and expiring cache for the Enhanced Monitoring Plugin ([PR #356](https://github.com/awslabs/aws-mysql-jdbc/pull/356), [PR #373](https://github.com/awslabs/aws-mysql-jdbc/pull/373)).
* Check log level to avoid unnecessary resource allocation ([PR #367](https://github.com/awslabs/aws-mysql-jdbc/pull/367)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Check log level to avoid unnecessary resource allocation ([PR #367](https://github.com/awslabs/aws-mysql-jdbc/pull/367)).
* Checked log level to avoid unnecessary resource allocation ([PR #367](https://github.com/awslabs/aws-mysql-jdbc/pull/367)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

CHANGELOG.md Outdated
* Optimized thread locks and expiring cache for the Enhanced Monitoring Plugin ([PR #356](https://github.com/awslabs/aws-mysql-jdbc/pull/356), [PR #373](https://github.com/awslabs/aws-mysql-jdbc/pull/373)).
* Check log level to avoid unnecessary resource allocation ([PR #367](https://github.com/awslabs/aws-mysql-jdbc/pull/367)).
* Updated README.md with the following
* `clusterInstanceHostPattern` Failover Parameter example ([here](https://github.com/awslabs/aws-mysql-jdbc#failover-parameters)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `clusterInstanceHostPattern` Failover Parameter example ([here](https://github.com/awslabs/aws-mysql-jdbc#failover-parameters)).
* `clusterInstanceHostPattern` failover parameter example ([here](https://github.com/awslabs/aws-mysql-jdbc#failover-parameters)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@karenc-bq karenc-bq merged commit 282c675 into awslabs:main Mar 30, 2023
@karenc-bq karenc-bq deleted the changelog-1.1.5 branch March 31, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants