fix(aws-apigateway-iot and aws-cloudfront-apigateway-lambda): fixed d…

…eprecated warnings (#554) * updated README for iot-sqs and kinesisstreams-gluejob * fixed deprecated warnings * empty commit
awslabs · Dec 21, 2021 · 655c4af · 655c4af
1 parent bf45829
commit 655c4af
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 20 deletions.
diff --git a/source/patterns/@aws-solutions-constructs/aws-apigateway-iot/README.md b/source/patterns/@aws-solutions-constructs/aws-apigateway-iot/README.md
@@ -78,7 +78,7 @@ Out of the box implementation of the Construct without any override will set the
 
 ### Amazon API Gateway
 
-* Deploy an edge-optimized API endpoint
+* Deploy an edge-optimized API Endpoint
 * Creates API Resources with `POST` Method to publish messages to IoT Topics
 * Creates API Resources with `POST` Method to publish messages to ThingShadow & NamedShadows
 * Enable CloudWatch logging for API Gateway

diff --git a/...onstructs/aws-cloudfront-apigateway-lambda/test/test.cloudfront-apigateway-lambda.test.ts b/...onstructs/aws-cloudfront-apigateway-lambda/test/test.cloudfront-apigateway-lambda.test.ts
@@ -153,9 +153,7 @@ test('override api gateway properties with existingLambdaObj', () => {
   new CloudFrontToApiGatewayToLambda(stack, 'test-cloudfront-apigateway-lambda', {
     existingLambdaObj: fn,
     apiGatewayProps: {
-      options: {
-        description: "Override description"
-      }
+      description: "Override description"
     }
   });
 
@@ -184,9 +182,7 @@ test('override api gateway properties without existingLambdaObj', () => {
       endpointConfiguration: {
         types: [api.EndpointType.PRIVATE],
       },
-      options: {
-        description: "Override description"
-      }
+      description: "Override description"
     }
   });
 

diff --git a/source/patterns/@aws-solutions-constructs/core/lib/apigateway-helper.ts b/source/patterns/@aws-solutions-constructs/core/lib/apigateway-helper.ts
@@ -101,21 +101,23 @@ function configureLambdaRestApi(scope: Construct, defaultApiGatewayProps: api.La
     cwRole = configureCloudwatchRoleForApi(scope, _api);
   }
 
-  let usagePlanProps: api.UsagePlanProps = {
+  // Configure Usage Plan
+  const usagePlanProps: api.UsagePlanProps = {
     apiStages: [{
       api: _api,
       stage: _api.deploymentStage
     }]
   };
-    // If requireApiKey param is set to true, create a api key & associate to Usage Plan
+
+  const plan = _api.addUsagePlan('UsagePlan', usagePlanProps);
+
+  // If requireApiKey param is set to true, create a api key & associate to Usage Plan
   if (apiGatewayProps?.defaultMethodOptions?.apiKeyRequired === true) {
-    const extraParams = { apiKey: _api.addApiKey('ApiKey')};
-    usagePlanProps = Object.assign(usagePlanProps, extraParams);
+    // Configure Usage Plan with API Key
+    const key = _api.addApiKey('ApiKey');
+    plan.addApiKey(key);
   }
 
-  // Configure Usage Plan
-  _api.addUsagePlan('UsagePlan', usagePlanProps);
-
   // Return the API and CW Role
   return [_api, cwRole];
 }
@@ -152,22 +154,23 @@ function configureRestApi(scope: Construct, defaultApiGatewayProps: api.RestApiP
     cwRole = configureCloudwatchRoleForApi(scope, _api);
   }
 
-  let usagePlanProps: api.UsagePlanProps = {
+  // Configure Usage Plan
+  const usagePlanProps: api.UsagePlanProps = {
     apiStages: [{
       api: _api,
       stage: _api.deploymentStage
     }]
   };
 
+  const plan = _api.addUsagePlan('UsagePlan', usagePlanProps);
+
   // If requireApiKey param is set to true, create a api key & associate to Usage Plan
   if (apiGatewayProps?.defaultMethodOptions?.apiKeyRequired === true) {
-    const extraParams = { apiKey: _api.addApiKey('ApiKey')};
-    usagePlanProps = Object.assign(usagePlanProps, extraParams);
+    // Configure Usage Plan with API Key
+    const key = _api.addApiKey('ApiKey');
+    plan.addApiKey(key);
   }
 
-  // Configure Usage Plan
-  _api.addUsagePlan('UsagePlan', usagePlanProps);
-
   // Return the API and CW Role
   return [_api, cwRole];
 }