Update defaults per TFC

awslabs · Jan 8, 2022 · 8ff3d37 · 8ff3d37
1 parent 42017cb
commit 8ff3d37
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 58 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/...s-solutions-constructs/aws-alb-fargate/test/integ.all-existing-private-http.expected.json b/...s-solutions-constructs/aws-alb-fargate/test/integ.all-existing-private-http.expected.json
@@ -902,7 +902,7 @@
           {
             "Essential": true,
             "Image": "nginx",
-            "MemoryReservation": 1024,
+            "MemoryReservation": 512,
             "Name": "test-container",
             "PortMappings": [
               {
@@ -912,9 +912,9 @@
             ]
           }
         ],
-        "Cpu": "512",
+        "Cpu": "256",
         "Family": "allexistingprivatehttptesttaskdefFB96B83E",
-        "Memory": "1024",
+        "Memory": "512",
         "NetworkMode": "awsvpc",
         "RequiresCompatibilities": [
           "FARGATE"
@@ -985,8 +985,8 @@
           "Ref": "testclusterDF8B0D19"
         },
         "DeploymentConfiguration": {
-          "MaximumPercent": 200,
-          "MinimumHealthyPercent": 100
+          "MaximumPercent": 150,
+          "MinimumHealthyPercent": 75
         },
         "DesiredCount": 2,
         "EnableECSManagedTags": false,

diff --git a/...ns/@aws-solutions-constructs/aws-alb-fargate/test/integ.all-new-public-http.expected.json b/...ns/@aws-solutions-constructs/aws-alb-fargate/test/integ.all-new-public-http.expected.json
@@ -1172,7 +1172,7 @@
           {
             "Essential": true,
             "Image": "nginx",
-            "MemoryReservation": 1024,
+            "MemoryReservation": 512,
             "Name": "test-construct-container",
             "PortMappings": [
               {
@@ -1182,9 +1182,9 @@
             ]
           }
         ],
-        "Cpu": "512",
+        "Cpu": "256",
         "Family": "allnewpublichttptestconstructtaskdefDF932EBD",
-        "Memory": "1024",
+        "Memory": "512",
         "NetworkMode": "awsvpc",
         "RequiresCompatibilities": [
           "FARGATE"
@@ -1255,8 +1255,8 @@
           "Ref": "testconstructcluster7B6231C5"
         },
         "DeploymentConfiguration": {
-          "MaximumPercent": 200,
-          "MinimumHealthyPercent": 100
+          "MaximumPercent": 150,
+          "MinimumHealthyPercent": 75
         },
         "DesiredCount": 2,
         "EnableECSManagedTags": false,

diff --git a/...ns/@aws-solutions-constructs/aws-alb-fargate/test/integ.all-new-two-targets.expected.json b/...ns/@aws-solutions-constructs/aws-alb-fargate/test/integ.all-new-two-targets.expected.json
@@ -1199,7 +1199,7 @@
           {
             "Essential": true,
             "Image": "nginx",
-            "MemoryReservation": 1024,
+            "MemoryReservation": 512,
             "Name": "test-construct-container",
             "PortMappings": [
               {
@@ -1209,9 +1209,9 @@
             ]
           }
         ],
-        "Cpu": "512",
+        "Cpu": "256",
         "Family": "allnewtwotargetstestconstructtaskdef8EF55A85",
-        "Memory": "1024",
+        "Memory": "512",
         "NetworkMode": "awsvpc",
         "RequiresCompatibilities": [
           "FARGATE"
@@ -1282,8 +1282,8 @@
           "Ref": "testconstructcluster7B6231C5"
         },
         "DeploymentConfiguration": {
-          "MaximumPercent": 200,
-          "MinimumHealthyPercent": 100
+          "MaximumPercent": 150,
+          "MinimumHealthyPercent": 75
         },
         "DesiredCount": 2,
         "EnableECSManagedTags": false,

diff --git a/source/patterns/@aws-solutions-constructs/core/lib/fargate-defaults.ts b/source/patterns/@aws-solutions-constructs/core/lib/fargate-defaults.ts
@@ -26,16 +26,16 @@ export function DefaultFargateServiceProps(
   return {
     assignPublicIp: false,
     desiredCount: 2,
-    maxHealthyPercent: 200,
-    minHealthyPercent: 100,
+    maxHealthyPercent: 150,
+    minHealthyPercent: 75,
     platformVersion: ecs.FargatePlatformVersion.LATEST,
   };
 }
 
 export function DefaultFargateTaskDefinitionProps(): ecs.FargateTaskDefinitionProps {
   return {
-    cpu: 512,
-    memoryLimitMiB: 1024,
+    cpu: 256,
+    memoryLimitMiB: 512,
   };
 }
 
@@ -52,7 +52,7 @@ export function DefaultApplicationTargetGroupProps(vpc: ec2.IVpc): elb.Applicati
 
 export function DefaultContainerDefinitionProps(): ecs.ContainerDefinitionOptions | any {
   return {
-    memoryReservationMiB: 1024,
+    memoryReservationMiB: 512,
     portMappings: [ { containerPort: 8080 } ],
   };
 }
diff --git a/source/patterns/@aws-solutions-constructs/core/test/fargate-helper.test.ts b/source/patterns/@aws-solutions-constructs/core/test/fargate-helper.test.ts
@@ -36,8 +36,8 @@ test('Test with all defaults', () => {
       Ref: "testclusterDF8B0D19"
     },
     DeploymentConfiguration: {
-      MaximumPercent: 200,
-      MinimumHealthyPercent: 100
+      MaximumPercent: 150,
+      MinimumHealthyPercent: 75
     },
     DesiredCount: 2,
     EnableECSManagedTags: false,
@@ -115,8 +115,8 @@ test('Test with all defaults in isolated VPC', () => {
       Ref: "testclusterDF8B0D19"
     },
     DeploymentConfiguration: {
-      MaximumPercent: 200,
-      MinimumHealthyPercent: 100
+      MaximumPercent: 150,
+      MinimumHealthyPercent: 75
     },
     DesiredCount: 2,
     EnableECSManagedTags: false,