-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(README.md): add python and java minimal deployment #582
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
7e002ef
added python min deployment and removed initializers
mickychetta ed641d6
pulled from main
mickychetta 4ca5cd1
fixed merge conflict
mickychetta aaeadc7
changed to v1 imports in deprecated constructs
mickychetta 886faff
added python min dep in new constructs
mickychetta f62ade7
added java minimal deployment code
mickychetta f987485
Merge branch 'main' of https://github.com/mickychetta/aws-solutions-c…
mickychetta 279d872
fixed java builder prop defintion
mickychetta 36aad3f
fixed indentation
mickychetta d2a7961
Merge branch 'main' into 552
mickychetta 5cc1615
fixed indentation
mickychetta 94bedd0
Merge branch 'main' of https://github.com/mickychetta/aws-solutions-c…
mickychetta c575709
fixed imports
mickychetta 47726c4
Merge branch 'main' into 552
mickychetta 593f5f8
updated python minimal deployments
mickychetta 8900c41
merged main
mickychetta bcc7c32
Merge branch 'main' into 552
mickychetta 033db99
updated java minimal deployments
mickychetta 8af7579
Merge branch '552' of https://github.com/mickychetta/aws-solutions-co…
mickychetta e7ebda6
updated to correct prop in route53-apigateway
mickychetta e664c83
updated python minimal deployments
mickychetta 4e23feb
cast to type Any in python example
mickychetta a7872b8
updated java minimal deployments
mickychetta 722f2b4
Merge branch 'main' into 552
mickychetta 668b655
updated java minimal deployments
mickychetta 0b6f68a
Merge branch '552' of https://github.com/mickychetta/aws-solutions-co…
mickychetta aa3235e
updated typescript minimal deployments
mickychetta 8b29c06
added viperlight ignore to README with fake account numbers
mickychetta eae978f
added viperlight ignore to README with fake account numbers
mickychetta 747fee9
added v1 deprecated comments in v1 constructs
mickychetta c2b9177
Merge branch 'main' into 552
mickychetta b13e0f3
Merge branch 'main' into 552
mickychetta e3e738f
Merge branch 'main' of https://github.com/mickychetta/aws-solutions-c…
mickychetta 24e6778
Merge branch 'main' into 552
mickychetta 3a7bff7
changed asset name in aws-lambda-sqs-lambda
mickychetta 3087604
Merge branch '552' of https://github.com/mickychetta/aws-solutions-co…
mickychetta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indent doesn't match the indent in the next function call (line 68). I know that indentions are important in Python ([sarcasm]one of the things I love so much about it[/sarcasm]), we should be consistent.