Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create cognito userpool client that exports both client ID and … #214

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alxyok
Copy link

@alxyok alxyok commented Oct 9, 2024

…client secret to a kubernetes secret (connection details)

What does this PR do?

Introduces a new Crossplane Composition and an XRD for managing AWS Cognito User Pool Clients. The composition enables automated provisioning of UserPoolClient resources based on user-specified inputs and writes connection secrets for the client, including and especially both the client ID and client secret.

Motivation

The current version of the UserPoolClient in the cognito-idp family of providers by AWS only exports client ID as a connection detail. It does not support client secret, which makes it useless if you want to reuse both of those details in other kubernetes resources such as exporting those in two SSM parameters or a secret in Secrets Manager.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant