Feature: Row Level Results #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsharma26
reviewed
Feb 16, 2023
rdsharma26
reviewed
Feb 16, 2023
| @@ -41,4 +41,6 @@ case class MaxLength(column: String, where: Option[String] = None) | |||
| } | |||
|
|
|||
| override def filterCondition: Option[String] = where | |||
|
|
|||
| private def criterion: Column = length(conditionalSelection(column, where)).cast(DoubleType) | |||
There was a problem hiding this comment.
This is a private method here and a public method in Completeness. If it is required in each analyzer, should it be part of a base class?
There was a problem hiding this comment.
the other one is used by a test that constructs an expected object and compares the result of Completeness to that object. It shouldn't be public because I don't think anything in the code should invoke it. I'll make it package-private inside deequ and mark it as @VisibleForTesting to point out it's an internal detail for the analyzer
rdsharma26
reviewed
Feb 16, 2023
rdsharma26
reviewed
Feb 16, 2023
|
Opening this against master instead #452 |
mentekid
force-pushed
the
feature/row-level-results
branch
from
982e54d
to
4147997
Compare
|
Thanks for updating the branch to master. LGTM. |
rdsharma26
approved these changes
Feb 22, 2023
rdsharma26
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Demo implementation of returning row-level results from metrics * Row-level results from VerificationResult * Row-level results from VerificationResult * Fix some tests by expecting a full result column * Fix Deequ tests to expect full Completeness result * Checks can return row-level result column names, if any * Make Analyzer and Constraint classes serializable explicitly * Refactor tests * Move row-level management to trait * MaxLength analyzer returns length of each record * Refactor VerificationResult to correctly match Metrics to Analyzers * VerificationResult aggregates all columns for a check * Return row-level results for two constraints * Improve naming and comments --------- Co-authored-by: Yannis Mentekidis <[email protected]>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Demo implementation of returning row-level results from metrics * Row-level results from VerificationResult * Row-level results from VerificationResult * Fix some tests by expecting a full result column * Fix Deequ tests to expect full Completeness result * Checks can return row-level result column names, if any * Make Analyzer and Constraint classes serializable explicitly * Refactor tests * Move row-level management to trait * MaxLength analyzer returns length of each record * Refactor VerificationResult to correctly match Metrics to Analyzers * VerificationResult aggregates all columns for a check * Return row-level results for two constraints * Improve naming and comments --------- Co-authored-by: Yannis Mentekidis <[email protected]>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Demo implementation of returning row-level results from metrics * Row-level results from VerificationResult * Row-level results from VerificationResult * Fix some tests by expecting a full result column * Fix Deequ tests to expect full Completeness result * Checks can return row-level result column names, if any * Make Analyzer and Constraint classes serializable explicitly * Refactor tests * Move row-level management to trait * MaxLength analyzer returns length of each record * Refactor VerificationResult to correctly match Metrics to Analyzers * VerificationResult aggregates all columns for a check * Return row-level results for two constraints * Improve naming and comments --------- Co-authored-by: Yannis Mentekidis <[email protected]>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Demo implementation of returning row-level results from metrics * Row-level results from VerificationResult * Row-level results from VerificationResult * Fix some tests by expecting a full result column * Fix Deequ tests to expect full Completeness result * Checks can return row-level result column names, if any * Make Analyzer and Constraint classes serializable explicitly * Refactor tests * Move row-level management to trait * MaxLength analyzer returns length of each record * Refactor VerificationResult to correctly match Metrics to Analyzers * VerificationResult aggregates all columns for a check * Return row-level results for two constraints * Improve naming and comments --------- Co-authored-by: Yannis Mentekidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This is an early version of the row-level results feature. I have enabled row-level results in three constraints:
IsComplete,HasCompleteness, andMaxLength.This requires the definition and change of certain classes defined in Deequ both to expose information previously not available, and to allow distinguishing between different analyzers' results.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.