Fix chi-square test conditions #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 11, 2023 15:08
Bug fix of chi-square test condition
|
@rdsharma26 could you please review this fix ? One edge case was not handled correctly. Thank you |
mentekid
approved these changes
May 23, 2023
rdsharma26
pushed a commit
that referenced
this pull request
Jul 3, 2023
* add population stability index function * add population stability index function * correct style issues * refactor psi formula * update imports * add population stability index function Bug fix of chi-square test condition * correct style issues --------- Co-authored-by: Bever <[email protected]>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add population stability index function * add population stability index function * correct style issues * refactor psi formula * update imports * add population stability index function Bug fix of chi-square test condition * correct style issues --------- Co-authored-by: Bever <[email protected]>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add population stability index function * add population stability index function * correct style issues * refactor psi formula * update imports * add population stability index function Bug fix of chi-square test condition * correct style issues --------- Co-authored-by: Bever <[email protected]>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add population stability index function * add population stability index function * correct style issues * refactor psi formula * update imports * add population stability index function Bug fix of chi-square test condition * correct style issues --------- Co-authored-by: Bever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chi-square test is only be conducted when the key size of the expected dataset is greater equal the minium.
Additional tests have been added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.