Add Spark 3.5 support #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchee
commented
Oct 25, 2023
| @@ -59,7 +59,7 @@ private[sql] case class StatefulHyperloglogPlus( | |||
|
|
|||
| override def dataType: DataType = BinaryType | |||
|
|
|||
| override def aggBufferSchema: StructType = StructType.fromAttributes(aggBufferAttributes) | |||
| override def aggBufferSchema: StructType = DataTypeUtils.fromAttributes(aggBufferAttributes) | |||
There was a problem hiding this comment.
StructType.fromAttributes has been refactored into DataTypeUtils.fromAttributes
Reference: apache/spark@8ff6b7a
There was a problem hiding this comment.
This looks good, it would be great if we could approve and merge this so that we could use it with V3.5
|
@eycho-am Would you mind to take a look on this, thanks again! |
mentekid
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#507
Description of changes:
mvn clean packagerun successfully on my local machine. Test result is as followed:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.