Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve features and CI #576

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Improve features and CI #576

merged 8 commits into from
Sep 5, 2024

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Sep 4, 2024 •
edited
Loading

Description of changes

  • Add CI for each feature
  • Remove tokio full and use scoped features
  • Relax versions for dependencies

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

richarddavison
richarddavison requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor comments

.github/workflows/build-modules.yml Show resolved Hide resolved
llrt_modules/Cargo.toml Show resolved Hide resolved
@richarddavison richarddavison merged commit 5e0e397 into awslabs:main Sep 5, 2024
9 checks passed
@Sytten Sytten deleted the ef-improve-features branch September 11, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richarddavison richarddavison richarddavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sytten @richarddavison