Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improved package.json resolution logic #672

Merged
merged 3 commits into from
Nov 9, 2024
Merged

fix: Improved package.json resolution logic #672

merged 3 commits into from
Nov 9, 2024

Conversation

nabetti1720
Copy link
Contributor

Issue # (if available)

Fixed #671

Description of changes

  • Fix package.json so that “index” is used as the name of the file directly under it when the resolved result is a directory.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison richarddavison merged commit 0a7509d into awslabs:main Nov 9, 2024
9 checks passed
@nabetti1720 nabetti1720 deleted the fix/resolve-package-json branch November 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richarddavison richarddavison richarddavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IO error occurs if package.json resolution results in a directory
2 participants
@nabetti1720 @richarddavison