Revert from GitHub METIS/ParMETIS distributions to PETSc forks #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tches and resolutions with recent version bugs
sebastiangrimberg
added
build
sebastiangrimberg
force-pushed
the
sjg/metis-build-dev
branch
from
7e7e643
to
83d0f13
Compare
13 tasks
mkandes
added a commit
to sdsc/spack
that referenced
this pull request
Oct 3, 2024
Note, however, the Spack package for metis (and parmetis) needs to be updated to use the latest patched versions of [email protected] from the PETSc project's fork for a number of reasons [1]. [1] awslabs/palace#170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be a number of issues with the recent GitHub repositories for METIS and ParMETIS published by KarypisLab. See the following and the issues referencing them:
schwarz_cppon macOS hpddm/hpddm#110In particular, some breaking changes have not been propagated correctly to downstream dependencies which leads to unanticipated behavior or breakage (MUMPS, SuperLU_DIST, and STRUMPACK all use METIS reordering). The consensus seems that package managers are sticking with the old v5.1.0 of METIS.
This PR reverts the METIS/ParMETIS builds to use the same versions used by PETSc:
These include a number of patches (KarypisLab/METIS#6) and are widely tested to give Palace users more confidence. We also include a couple of minor patches on top of the PETSc forks to silence compiler warnings, including updating the minimum CMake version, fixing ambiguous indentation issues, resolving a bug where
abswas called instead offabsfor a floating point argument, and fixing a potential buffer overrun in file IO.