feat: add support for XRPL message ID #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a custom XRPL message ID, which comprises of just a 32-byte hash.
To initiate bridging from XRPL, a
Paymenttransaction is made into an XRPL multisig (which can be though of as a replacement for theAxelarGateway).Since XRPL does not support batched transactions, there can only be one bridging transaction per XRPL transaction, so an event index is redundant.
Todos
Steps to Test
Expected Behaviour
Other Notes
We do not have full context of all the moving pieces that this PR affects. Please review and let us know if you see any issues or recommend any changes.