Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(service-registry): remove unused config from state file #569

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

maancham
Copy link
Contributor

@maancham maancham commented Aug 2, 2024

Description

AXE-4607

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@maancham maancham requested a review from a team as a code owner August 2, 2024 20:17
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (bf11cc6) to head (93d1a63).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         190      190           
  Lines       26907    26906    -1     
=======================================
  Hits        25283    25283           
+ Misses       1624     1623    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maancham maancham merged commit a0ee664 into main Aug 2, 2024
6 checks passed
@maancham maancham deleted the refactor/service-registry-config branch August 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants