Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor-ampd): reject missing chain in register chain support command #633

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

cjcobb23
Copy link
Contributor

@cjcobb23 cjcobb23 commented Sep 19, 2024

@cjcobb23 cjcobb23 requested a review from a team as a code owner September 19, 2024 18:15
@cjcobb23 cjcobb23 changed the title fix(minor-ampd): reject 0 length chains vec in register chain support fix(minor-ampd): reject empty chains list in register chain support Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.54%. Comparing base (05dbeea) to head (869ef72).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ampd/src/commands/register_chain_support.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         241      241           
  Lines       33883    33883           
=======================================
  Hits        31697    31697           
  Misses       2186     2186           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ampd/src/commands/register_chain_support.rs Outdated Show resolved Hide resolved
ampd/src/commands/register_chain_support.rs Show resolved Hide resolved
@cjcobb23 cjcobb23 changed the title fix(minor-ampd): reject empty chains list in register chain support fix(minor-ampd): reject missing chain in register chain support command Sep 20, 2024
@cjcobb23 cjcobb23 merged commit 8da4b8c into main Sep 20, 2024
6 checks passed
@cjcobb23 cjcobb23 deleted the ampd_register_chain_support branch September 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants