feat: gas service #3

canhtrinh · 2024-02-26T19:42:46Z

Draft PR with remaining questions:

can we review overall structure of this impl? largely followed the structure of the gateway contracts but want to ensure it follows the same proxy/impl approach we want
for amounts, the solidity gas services uses u256 but transfer methods for tokens take i128.
what is the right pattern for auth? for example, want to make sure collect_fees and refund can only be invoked by gas_collector (which, in our Solidity impl, are set in the contract constructor) UPDATE: think i see the pattern, but do still want to discuss it before this is merged
how to check for address zero?
in my tests, not getting token transfers to work.
in my tests, not getting assertion of emitted events to work.

contracts/axelar-gas-service/src/test.rs

chore: add back contract_id as output to the setup_emv test chore: update tests to pass in correct token address into refund chore: WIP - adding auth for refund methods and tests for emitted events chore: unwrapping index value

codecov-commenter · 2024-03-05T15:50:40Z

Codecov Report

Attention: Patch coverage is 96.35628% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92.30%. Comparing base (65a0891) to head (a8fb7b8).

Files	Patch %	Lines
contracts/axelar-gas-service/src/contract.rs	95.45%	4 Missing ⚠️
contracts/axelar-gas-service/src/error.rs	0.00%	2 Missing ⚠️
contracts/axelar-gas-service/src/storage_types.rs	50.00%	1 Missing ⚠️
...xelar-soroban-interfaces/src/axelar_gas_service.rs	0.00%	1 Missing ⚠️
packages/axelar-soroban-std/src/types.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   91.21%   92.30%   +1.08%     
==========================================
  Files          19       26       +7     
  Lines         922     1169     +247     
==========================================
+ Hits          841     1079     +238     
- Misses         81       90       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/axelar-gas-service/Cargo.toml

contracts/axelar-gas-service/src/test.rs

contracts/axelar-gas-service/src/types.rs

contracts/axelar-gas-service/src/test.rs

Co-authored-by: Milap Sheth <[email protected]>

chore: fmt code chore: run cargo sort

contracts/axelar-soroban-interfaces/src/axelar_gas_service.rs

contracts/axelar-gas-service/src/contract.rs

contracts/axelar-soroban-interfaces/src/axelar_gas_service.rs

contracts/axelar-gas-service/src/event.rs

packages/axelar-soroban-std/src/types.rs

contracts/axelar-gas-service/src/contract.rs

Co-authored-by: Milap Sheth <[email protected]>

chore: incorporate add'l comments

contracts/axelar-gas-service/src/contract.rs

contracts/axelar-gas-service/src/event.rs

contracts/axelar-gas-service/src/test.rs

Co-authored-by: Milap Sheth <[email protected]>

canhtrinh changed the title ~~Feat/gas service~~ feat: gas service Feb 27, 2024

haiyizxx reviewed Mar 1, 2024

View reviewed changes

contracts/axelar-gas-service/src/test.rs Outdated Show resolved Hide resolved

canhtrinh force-pushed the feat/gas-service branch from 3e748bb to 5e742d2 Compare March 4, 2024 21:46

canhtrinh added 4 commits March 5, 2024 10:47

feat: add workspace for axelar gas service

cdd734d

feat: add refund impl and set up tests

b79b41e

feat: add impl for pay_native_gas_for_contract_call

5dee6ab

feat: implement collect_fees

e3c403e

chore: add back contract_id as output to the setup_emv test chore: update tests to pass in correct token address into refund chore: WIP - adding auth for refund methods and tests for emitted events chore: unwrapping index value

canhtrinh force-pushed the feat/gas-service branch from 5e742d2 to e3c403e Compare March 5, 2024 15:47

canhtrinh force-pushed the feat/gas-service branch from 2637276 to 35b31c6 Compare March 6, 2024 03:36

feat: update gas service unit tests

b7d0b57

canhtrinh force-pushed the feat/gas-service branch from 35b31c6 to b7d0b57 Compare March 6, 2024 03:39

canhtrinh marked this pull request as ready for review March 6, 2024 03:41

chore: remove vec from and add emitted event to collect_fees api

db1cc0f

canhtrinh requested a review from a team as a code owner March 7, 2024 17:01

chore: cargo fmt

49747d0

canhtrinh force-pushed the feat/gas-service branch from 7fec4e5 to 49747d0 Compare March 7, 2024 20:20

milapsheth reviewed Mar 14, 2024

View reviewed changes

canhtrinh and others added 12 commits March 14, 2024 09:42

Update contracts/axelar-gas-service/Cargo.toml

145c26b

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/Cargo.toml

50cf1c3

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/contract.rs

32a13ae

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/test.rs

8941d2a

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/error.rs

42b2270

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/event.rs

85260a1

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/event.rs

48553de

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/event.rs

ee25e75

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/event.rs

4aac186

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/interface.rs

a016bfc

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/lib.rs

e8735eb

Co-authored-by: Milap Sheth <[email protected]>

chore: merge latest main

f54e251

chore: addressing latest comments on gas-service PR

3a15f92

canhtrinh force-pushed the feat/gas-service branch from d585dca to af2b7bc Compare March 17, 2024 04:42

chore: fmt code

ac472f4

chore: fmt code chore: run cargo sort

canhtrinh force-pushed the feat/gas-service branch from af2b7bc to ac472f4 Compare March 17, 2024 04:47

chore: reduce parameter list size in pay_gas_for_contract_call

12e4837

milapsheth reviewed Mar 18, 2024

View reviewed changes

milapsheth and others added 10 commits March 17, 2024 21:58

Merge branch 'main' into feat/gas-service

f68df95

Update contracts/axelar-soroban-interfaces/src/axelar_gas_service.rs

884d414

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-soroban-interfaces/src/axelar_gas_service.rs

a9184fd

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/contract.rs

a2c9bef

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-soroban-interfaces/src/axelar_gas_service.rs

628bb19

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/contract.rs

29c07ef

Co-authored-by: Milap Sheth <[email protected]>

Update packages/axelar-soroban-std/src/types.rs

4be6a51

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-soroban-interfaces/src/axelar_gas_service.rs

0a2063a

Co-authored-by: Milap Sheth <[email protected]>

chore: refactor gas service

b76738b

chore: incorporate add'l comments

chore: update pay_gas_for_contract_call to use tranfer_from

cccc748

milapsheth approved these changes Mar 19, 2024

View reviewed changes

canhtrinh and others added 6 commits March 19, 2024 01:24

Update contracts/axelar-gas-service/src/event.rs

f9d764a

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/contract.rs

c613025

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/contract.rs

b6b56ac

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/test.rs

5299355

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/axelar-gas-service/src/test.rs

8538ef6

Co-authored-by: Milap Sheth <[email protected]>

chore: fix tests with variable name change

a8fb7b8

canhtrinh merged commit 64fdccf into main Mar 19, 2024
5 checks passed

canhtrinh deleted the feat/gas-service branch March 19, 2024 05:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: gas service #3

feat: gas service #3

canhtrinh commented Feb 26, 2024 •

edited

Loading

codecov-commenter commented Mar 5, 2024 •

edited

Loading

feat: gas service #3

feat: gas service #3

Conversation

canhtrinh commented Feb 26, 2024 • edited Loading

codecov-commenter commented Mar 5, 2024 • edited Loading

Codecov Report

canhtrinh commented Feb 26, 2024 •

edited

Loading

codecov-commenter commented Mar 5, 2024 •

edited

Loading