adds register operation to Parser #58

Miiike89 · 2020-06-18T05:49:09Z

- enables the User to register new operations, which can be parsed by Parser

- enables the User to register new operations, which can be parsed by Parser

cansadadeserfeliz · 2020-06-18T22:10:27Z

@Miiike89 please, add some unit tests

jeffreyscottgraham · 2020-06-19T17:09:01Z

py_expression_eval/__init__.py

+
+    def register_operation(self, token, priority, index, func):
+
+        if token not in self.ops1 or token not in self.ops1:


um.... this seems wrong... same check of ops1 twice? And not checking ops ?
And then adding it to yet another called ops2?

Yeah, you guys are right. It worked for my simple cases, but indeed there is a lack of errorhandling and unittests. I'am sorry, about that.
Unfortunately I'am currently quite swamped at work and won´t be able to fix this right away. You guys have to give me some time, please.

adds register operation to Parser

a13357c

- enables the User to register new operations, which can be parsed by Parser

jeffreyscottgraham reviewed Jun 19, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds register operation to Parser #58

adds register operation to Parser #58

Miiike89 commented Jun 18, 2020

cansadadeserfeliz commented Jun 18, 2020

jeffreyscottgraham Jun 19, 2020 •

edited

Loading

Miiike89 Jun 22, 2020


		def register_operation(self, token, priority, index, func):

		if token not in self.ops1 or token not in self.ops1:

adds register operation to Parser #58

Are you sure you want to change the base?

adds register operation to Parser #58

Conversation

Miiike89 commented Jun 18, 2020

cansadadeserfeliz commented Jun 18, 2020

jeffreyscottgraham Jun 19, 2020 • edited Loading

Choose a reason for hiding this comment

Miiike89 Jun 22, 2020

Choose a reason for hiding this comment

jeffreyscottgraham Jun 19, 2020 •

edited

Loading