-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding option to disable automatic decompression #2661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzy4o
changed the title
Adding: Ability to disable automatic decompression
Adding: Ability to disable automatic decompression #2153
Jan 23, 2020
chinesedfan
suggested changes
Feb 16, 2020
chinesedfan
approved these changes
Feb 29, 2020
chinesedfan
changed the title
Adding: Ability to disable automatic decompression #2153
Adding option to disable automatic decompression
Mar 6, 2020
This was referenced Mar 24, 2020
Closed
When will this feature release? It's documented on README but the latest release 0.19.2 doesn't include this feature. |
@Fonger I am not sure when the next release will be. This was merged in shortly after the last release. If you want to use this feature now, fork
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes you do not want the response body of an http request automatically decompressed. For example if you are immediately storing response body or are passing response body on to to another service. Closed #2153.
Solution
Add a parameter to config to allow developer to disable automatic decompression
Change summary
decompress
to config typingFix lint error in unit tests(reverted)decompress
parameterIt has been pointed out that this feature may not be accepted since it only applies to Node.js, but this is an extremely useful feature, so I think it should be included in the official axios package
Please let me know if there is anything that I should change