Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unused extensions in the FairyGUI and Live2D tests to speed up builds #1665

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Feb 10, 2024

Which branch your pull-request should merge into?

  • 2.1: BugFixes and Improvements for Current LTS branch

Describe your changes

The Live2D and FairyGUI test projects do not require all extensions to be enabled, so the ones that are not used are now disabled to speed up the build process.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Copy link
Collaborator

@halx99 halx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put to NOT DEFINED BUILD_ENGINE_DONE is better, which means build test as top level project

@rh101
Copy link
Contributor Author

rh101 commented Feb 11, 2024

put to NOT DEFINED BUILD_ENGINE_DONE is better, which means build test as top level project

Oh yes, makes sense. I'll change it now.

@halx99 halx99 merged commit 0f3c7d3 into axmolengine:2.1 Feb 11, 2024
8 checks passed
@halx99 halx99 added this to the 2.1.2 milestone Feb 11, 2024
@rh101 rh101 deleted the disable-unused-extensions branch February 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants