Fix glfw crash on macOS for large mouse button ids #1835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
On macOS GLFW crashes with mouse button id 8. This PR is a temporary workaround until GLFW will release a fix. Crash is at
assert(button <= GLFW_MOUSE_BUTTON_LAST);
in this function:axmol/3rdparty/glfw/src/input.c
Lines 345 to 368 in d03c823
GLFW_MOUSE_BUTTON_LAST is 7, so assert is triggered. GLFW seems has fixed this a month ago by also removing this assert, but it's not released yet. Fix commit is here: glfw/glfw@bf945f1
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR