Add support for necessary events to be sent regardless of event dispatcher enabled state #1940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If the event dispatcher is disabled, then necessary events such as
EVENT_RENDERER_RECREATED
,EVENT_APP_RESTARTING
,EVENT_COME_TO_FOREGROUND
, andEVENT_COME_TO_BACKGROUND
will not be sent, which in certain instances will result in application crashes.An example case:
1 - event dispatcher is disabled (such as on entering a scene transition)
2 - the app is moved to the background for any reason
3 - the app is then moved back to the foreground
4 - if the EGL context is lost, then it will attempt to recover/restart depending on the configuration (AX_ENABLE_CACHE_TEXTURE_DATA == 1 or AX_ENABLE_RESTART_APPLICATION_ON_CONTEXT_LOST == 1)
5 - since the event dispatcher is still disabled, EVENT_RENDERER_RECREATED (or EVENT_APP_RESTARTING) would never be sent out
Issue ticket number and link
Related issue: #1211
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR