Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve curl downloader #1999

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Improve curl downloader #1999

merged 1 commit into from
Jun 22, 2024

Conversation

halx99
Copy link
Collaborator

@halx99 halx99 commented Jun 21, 2024 •
edited
Loading

Describe your changes

  • Use curl_multi_poll instead select
  • Use curl_xferinfo_callback instead deprecated curl_progress_callback
  • Don't use CURL_HEADER to get content length, get it in xferinfo_callback.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the 2.1.4 milestone Jun 21, 2024
@halx99 halx99 added the enhancement New feature or request label Jun 21, 2024
@halx99 halx99 merged commit b6b6a15 into dev Jun 22, 2024
15 checks passed
@halx99 halx99 deleted the improve-downloader branch June 22, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
1 participant
@halx99