Handle premultiplied alpha for grayscale PNGs. #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for premultiplied alpha on grayscale PNGs with alpha.
The assignment of
Image::_hasPremultipliedAlphawas conditioned on the pixel format being RGBA8. Consequently, grayscale textures with alpha did not take this route and ended up with_hasPremultipliedAlpha = falsewhich would cause artifacts if the file actually did contain premultiplied alpha.In this commit I extend the conditional to include RA8 (RG8 in Axmol) and complete
Image::multiplyAlphato handle this case too.