Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine contributing.md guide #2135

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

Tosik86
Copy link
Contributor

@Tosik86 Tosik86 commented Sep 10, 2024

Describe your changes

I tried to refine "submitting patches" steps in CONTRIBUTING.md by adding steps from post #411

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@Tosik86 Tosik86 changed the title Tosik86/refine contributing md guide Refine contributing.md guide Sep 10, 2024
@halx99 halx99 merged commit c3d5476 into axmolengine:dev Sep 11, 2024
1 check passed
@halx99 halx99 added this to the 2.2.0 milestone Sep 11, 2024
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
* Refined submitting patches steps in CONTRIBUTING.md

* Add forgotten $ sign to CONTRIBUTING.md code snippet

* Add forgotten colon to CONTRIBUTING.md file
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
* Refined submitting patches steps in CONTRIBUTING.md

* Add forgotten $ sign to CONTRIBUTING.md code snippet

* Add forgotten colon to CONTRIBUTING.md file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants