-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize DrawNode #2165
Optimize DrawNode #2165
Conversation
@smilediver
See here: @halx99 @smilediver: |
It would be better if you did that, since you wrote it and know the code better.
Maybe it's better to remove it completely, since it's not doing anything anyway, and will mislead people. |
I will look after merge. |
@smilediver (@halx99) |
I read to late, yes can deleted. |
It's a bit field: https://en.cppreference.com/w/cpp/language/bit_field |
This PR does some DrawNode optimizations:
pod_vector
for storing and growing buffers.drawXXX()
is called.drawXXX()
methods in_transform()
.There's still a lot of
drawXXX()
methods that do unnecessary allocations that have a big impact on performance.Also there are
_lineWidth
and_defaultLineWidth
members that can be set by the user but do nothing. Seems like a bug that probably breaks old behavior.