replace for(auto <var> to for(auto& <var>

[aismann]

working with reference and not with copies
=> Performance issue

solve feature: #759

[halx99]

I think the raw iterator don't needs change to auto&, just c++11 for-loop needs for non-pointer element like:

for (auto& item : items)
    item.callSomeMethod();

[aismann]

I think the raw iterator don't needs change to auto&, just c++11 for-loop needs for non-pointer element like:

for (auto& item : items)
    item.callSomeMethod();

Correct! This one & was to much. Sorry. (removed it)

[aismann]

I think the raw iterator don't needs change to auto&, just c++11 for-loop needs for non-pointer element like:

for (auto& item : items)
    item.callSomeMethod();

@halx99
BTW: also lyasio.cpp has a: for (auto item : channel_eps) > can be changed to: for (auto& item : channel_eps)

At the moment a don't changing anything on thirtparty folders

[halx99]

The channel_ops element is store as pointer, so don't need change

[aismann]

The channel_ops element is store as pointer, so don't need change

I know. for (auto item : channel_eps) is no different to for (auto& item : channel_eps)
BUT: as an developer reading the sources its easier for understanding (its a ref not a copy).

[halx99]

Using c++11 Universal References maybe better like:

std::vector<bool> items1 = {false};
for(auto&& item : items1) 
    item = true;

const std::vector<bool> items2 = {true};
for (auto&& item : items2)
    printf("item=%d\n", (int)item);

[aismann]

Using c++11 Universal Reference maybe better like:

std::vector<bool> items1 = {false};
for(auto&& item : items1) 
    item = true;

const std::vector<bool> items2 = {true};
for (auto&& item : items2)
    printf("item=%d\n", (int)item);

Should I change ALL for (auto& <var1>: <var2>) to for (auto&& <var1>: <var2>) ?

[halx99]

Using c++11 Universal Reference maybe better like:

std::vector<bool> items1 = {false};
for(auto&& item : items1) 
    item = true;

const std::vector<bool> items2 = {true};
for (auto&& item : items2)
    printf("item=%d\n", (int)item);

Should I change ALL for (auto& <var1>: <var2>) to for (auto&& <var1>: <var2>) ?

Yes, you can, the Universal References can handle both const or non-const containers.

[aismann]

Also for the 'extension' folder?

The ThirtParty folder will be untouched

[halx99]

Also for the 'extension' folder?

The ThirtParty folder will be untouched

Yes, but should ignore spine, fairygui, Live2D

[aismann]

this extensions be untouched (spine, Live2D has no such C++11 for loop):
Also some tester ( for (auto& touch : touches) ) is good enough

[aismann]

finished.