Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve size-limit ci action #5

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Improve size-limit ci action #5

merged 4 commits into from
Jul 26, 2022

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Jul 25, 2022

In the continuity of the binary size reporting on PR, some fixes has been made.

  • Only trigger the report wasm action if the event is a pull request
  • Remove the size-limit configuration from package.json in replacement of .size-limit file. See 📏 Report binary size on PR #2 for more details why.
  • Put back the check_contract action removed on Ci/fix ci lint #3, fixing CI failures.

Maybe we need now to add a file size limitation configuration based on our smart contract requirement to make PR fails if the size is reached..

@bot-anik
Copy link
Member

bot-anik commented Jul 25, 2022

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/cw_template.wasm 182.06 KB (0%)

@bdeneux bdeneux force-pushed the fix/size-limit branch 2 times, most recently from d3c4a4c to cdfb7d0 Compare July 26, 2022 08:22
@bdeneux bdeneux force-pushed the fix/size-limit branch 2 times, most recently from f19226f to 3d96749 Compare July 26, 2022 09:20
@bdeneux bdeneux marked this pull request as ready for review July 26, 2022 09:39
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bdeneux bdeneux merged commit 7ab1b45 into main Jul 26, 2022
@bdeneux bdeneux deleted the fix/size-limit branch July 26, 2022 11:53
@bot-anik
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bot-anik
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants