🏭 build: replace sleep command by wait-tx

[bdeneux]

Since the removing of --broadcast-mode block options on cosmos-sdk, no equivalence was existing since the v0.50.6. This version introduce <appd> query wait-tx command to give the hash of the transaction to wait or get the STDIN to wait for the transaction registered in a block.

This PR also set the latest version of axoneprotocol/axoned published in docker.

Summary by CodeRabbit

• Chores
  • Updated Docker commands to include additional parameters for querying transactions.
  • Replaced --broadcast-mode sync with a new query command to wait on transactions.
  • Upgraded Docker image for DOCKER_IMAGE_AXONED to version 8.0.0.

[coderabbitai]

Walkthrough

The recent updates to the Makefile.toml involve refining the Docker commands for transaction queries and updating the Docker image for axoned. The --broadcast-mode sync option has been replaced with a new query command to wait for transactions, ensuring more efficient handling. Additionally, the Docker image has been upgraded from version 7.1.0 to 8.0.0, enhancing overall functionality and compatibility.

Changes

Files	Change Summary
Makefile.toml	Updated Docker commands to include additional parameters for querying transactions and replaced --broadcast-mode sync with a new query command.
Makefile.toml	Updated Docker image for DOCKER_IMAGE_AXONED from "axone/axoned:7.1.0" to "axoneprotocol/axoned:8.0.0".

Poem

In the land of code, a change took flight,
Docker commands refined, shining bright.
Axoned now at version eight,
Transactions query, never late.
With every tweak, we build and grow,
Hopping forward, in the know.
🌟🚀🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[bot-anik]

size-limit report 📦

Path	Size
target/wasm32-unknown-unknown/release/axone_objectarium.wasm	395.17 KB (0%)
target/wasm32-unknown-unknown/release/axone_law_stone.wasm	596.25 KB (0%)
target/wasm32-unknown-unknown/release/axone_cognitarium.wasm	760.48 KB (0%)
target/wasm32-unknown-unknown/release/axone_dataverse.wasm	621.05 KB (0%)

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2ed6cdc and 518a232.

Files selected for processing (1)

• Makefile.toml (4 hunks)

Additional comments not posted (4)

Makefile.toml (4)

436-440: Replace sleep with wait-tx to ensure transaction completion before proceeding.

This change aligns with the removal of the --broadcast-mode block option in cosmos-sdk and should enhance the reliability of the build process by ensuring that transactions are fully processed before moving on.

---

526-530: Ensure proper transaction handling with wait-tx in contract instantiation.

This modification is crucial for ensuring that the contract instantiation does not proceed until the transaction is confirmed, which is particularly important in automated scripts to prevent race conditions.

---

594-600: Use wait-tx for robust transaction handling in contract execution.

Adopting wait-tx here is a proactive measure to handle potential delays or issues in transaction processing, ensuring that the script only proceeds once the transaction is fully acknowledged by the network.

---

660-660: Update Docker image to axoneprotocol/axoned:8.0.0.

Upgrading to the latest Docker image version is a good practice to take advantage of the latest features and security patches. Ensure that this version is compatible with all dependencies and the overall environment.

[ccamel]

Great! Much better this way 😄

[amimart]

That makes my conscious much more cleaner thanks! 🙏

[bdeneux]

Now we can sleep (for real) peacefully 🙃