Ci/fix peers #753
Ci/fix peers #753
Conversation
WalkthroughThe changes encompass updates to the GitHub workflow and peer addresses for the Changes
Sequence Diagram(s) (Beta)The changes do not introduce a new feature or significantly alter the control flow, so a sequence diagram is not provided. Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
.github/workflows/update-peers.yml (1)
Line range hint
43-91: Enhanced peer retrieval logic with robust parsing and error handling.The peer retrieval script has been significantly improved. Consider encapsulating the peer address parsing logic into a separate function or module for better maintainability and potential reuse.
+ def parse_peer_address(peer): + peerId = peer['node_info']['id'] + remoteIp = peer['remote_ip'] + listen_address = peer['node_info']['listen_addr'] + match = re.match(r"(?:.+:\/\/)?(?:.+):(\d+)", listen_address) + if match: + listen_port = match.group(1) + else: + raise ValueError("Invalid listen address: {}".format(listen_address)) + + match ip_class(remoteIp): + case IPClass.IPv4: + return f"{peerId}@{remoteIp}:{listen_port}" + case IPClass.IPv6: + return f"{peerId}[@{remoteIp}]:{listen_port}" + case _: + raise ValueError("Invalid IP address: {}".format(remoteIp)) + + return parse_peer_address(peer)This refactor suggestion aims to improve the readability and maintainability of the code by separating concerns.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/update-peers.yml (4 hunks)
Additional comments not posted (2)
.github/workflows/update-peers.yml (2)
6-7: Scheduled run added for Mondays.This ensures the peer list is regularly updated, which is crucial for maintaining network connectivity.
19-20: Updated node and chain information.This change targets the
drunemeton-1network specifically, aligning with the PR's objectives to reactivate peer retrieval for this network.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- chains/drunemeton-1/peers.txt (1 hunks)
Additional comments not posted (6)
chains/drunemeton-1/peers.txt (6)
1-1: Updated peer address appears correctly formatted.
2-2: New peer address added and correctly formatted.
3-3: New peer address added and correctly formatted.
4-4: New peer address added and correctly formatted.
8-8: Updated peer address appears correctly formatted.
9-9: New peer address added and correctly formatted.
Reactivates
peersretrieval and update job for thedrunemeton-1network. It may not be absolutely essential, but it aims to be helpful, I guess.