-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry mechanism to uploader #53
base: master
Are you sure you want to change the base?
Conversation
P.S. Please take a look at |
@Pospelove sorry for the late response. I will have a look during the weekend. |
@ayeressian No worries, take your time! |
@Pospelove maybe using a lib like https://www.npmjs.com/package/fetch-retry will be a better solution |
BTW does this pass the tests? |
Thank you for taking a look! I'll consider updating my implementation with a Regarding tests, I didn't launch e2e tests in the repo, however my project uses the updated version on everyday basis. |
make-fetch-happen is also another option |
Hey @ayeressian!
There were some failures on BunnyCDN side recently resulting in
ECONNRESET
andsocket hang up
errors in my workflows.So, I added a simple retry mechanism to the uploader in your action.
Please let me know if you're interested and any changes required to land this PR.