Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry mechanism to uploader #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Pospelove
Copy link
Contributor

Hey @ayeressian!

There were some failures on BunnyCDN side recently resulting in ECONNRESET and socket hang up errors in my workflows.

So, I added a simple retry mechanism to the uploader in your action.

Please let me know if you're interested and any changes required to land this PR.

@Pospelove
Copy link
Contributor Author

P.S. Please take a look at dist/index.js. It worked perfectly for me but IDK if it's generally correct. Maybe there is something I don't know, like a specific NodeJS version required to build?

@ayeressian
Copy link
Owner

ayeressian commented Oct 25, 2024

@Pospelove sorry for the late response. I will have a look during the weekend.

@Pospelove
Copy link
Contributor Author

@ayeressian No worries, take your time!

@ayeressian
Copy link
Owner

@Pospelove maybe using a lib like https://www.npmjs.com/package/fetch-retry will be a better solution

@ayeressian
Copy link
Owner

BTW does this pass the tests?

@Pospelove
Copy link
Contributor Author

Thank you for taking a look! I'll consider updating my implementation with a fetch-retry lib.

Regarding tests, I didn't launch e2e tests in the repo, however my project uses the updated version on everyday basis.

@ayeressian
Copy link
Owner

make-fetch-happen is also another option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants