This repository has been archived by the owner on Nov 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
drop youtube_dl in favour of pytube #11
Open
CarlosDerSeher
wants to merge
22
commits into
aykevl:master
Choose a base branch
from
CarlosDerSeher:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SSDP DIAL response, added log messages
Added option for custom friendly name; format, device description file and app response updated
Format updated
Format updated
Format updated
Added function for getting data from app
Format updated, added function to return screenid
Format updated
Fixed custom port, format updated, added option to write sound to a file
Some changes and additions
Path rely on GOPATH
Added restart in case of failure
Changing word
Correct time format, fixes new version of chrome
Correct header format, fixes chrome detection
# Conflicts: # README.md
what about yt-dlp instead? |
Yeah. I don't really use this anymore, so... Also I heard youtube_dl is online again so there is no more use for this pull request I guess? |
I'm not using this project anymore so I'm not maintaining it either. Feel free to fork it if you want to continue using/maintaining it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent DMCA takedown of youtube_dl, I suggest to use pytube instead. Also it is much faster at fetching stream urls, at least when running on my raspberry pi 2.
Also I add a branch to use your code with snapcast, have a look if you like.