Do a much more thorough job with item times #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ha I assumed these failures were all because 0.4.0 of stac4s wasn't available yet oops. ANYWAY 🤞🏻 for this one |
pomadchin
approved these changes
May 12, 2021
| @@ -153,7 +153,7 @@ class CatalogStacImport(val catalogRoot: String) { | |||
| ) | |||
| ), | |||
| ().asJsonObject, | |||
| forItem.properties, | |||
| forItem.properties.asJson.asObject.getOrElse(JsonObject.empty), | |||
There was a problem hiding this comment.
Ouf, I also don't know how to handle it better.
There was a problem hiding this comment.
Yeah I spent about four seconds adding an Encoder.AsObject in stac4s but decided not to -- it's not hard but it didn't seem important enough
Comment on lines
+21
to
+27
| Some( | ||
| fr"(datetime >= $start AND datetime <= $end) OR (start_datetime >= $start AND end_datetime <= $end)" | ||
| ) | ||
| case Some(start) :: _ => | ||
| Some(fr"datetime >= $start") | ||
| Some(fr"(datetime >= $start OR start_datetime >= $start)") | ||
| case _ :: Some(end) :: _ => | ||
| Some(fr"datetime <= $end") | ||
| Some(fr"(datetime <= $end OR end_datetime <= $end)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes a few changes now that
stac4smodels datetimes better:datetime,start_datetime, andend_datetimefields as appropriate on item insert, bulk insert, and updatedatetimecolumnChecklist
Notes
CI is gonna fail until the stac4s release that just happened is resolvable in Maven. Might be soon.
Testing Instructions
Closes #724