Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DB): move 2023 update files #20470

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FrancescoBorzi
Copy link
Contributor

No description provided.

@github-actions github-actions bot added DB related to the SQL database Documentation labels Nov 6, 2024
@Kitzunu
Copy link
Member

Kitzunu commented Nov 6, 2024

You need to set the files as ARCHIVED in https://www.azerothcore.org/wiki/updates

@FrancescoBorzi
Copy link
Contributor Author

@Kitzunu done

@Nyeriah
Copy link
Member

Nyeriah commented Nov 9, 2024

Do we need to update the base database files before this?/along with this? @Kitzunu @FrancescoBorzi

@Nyeriah
Copy link
Member

Nyeriah commented Nov 9, 2024

Just afraid we might stash files not included in the base database. This is confusing :/

@Kitzunu
Copy link
Member

Kitzunu commented Nov 9, 2024

Anything 2023 is in base.
But we might want to update updates.sql in the base to reflect these changes

@Kitzunu
Copy link
Member

Kitzunu commented Nov 9, 2024

I agree it is confusing, as it has never been done before 😅 Who know what might happen.

But I don't think it will cause any issues and the base updates file says all these files are already imported anyways. So it will still only run files that are not in the table, so all files created after the last squash

@FrancescoBorzi
Copy link
Contributor Author

Anything 2023 is in base. But we might want to update updates.sql in the base to reflect these changes

yes, in my opinion that should have been done already when squashing those updates inside the base files. @Kitzunu can you please take care of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Documentation To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants