Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Scripts/TheEye): Fix Al'ar berserk timer #20572

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

Nyeriah
Copy link
Member

@Nyeriah Nyeriah commented Nov 15, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added Script file-cpp Used to trigger the matrix build labels Nov 15, 2024
@TheSCREWEDSoftware
Copy link
Contributor

TheSCREWEDSoftware commented Nov 15, 2024

Something wrong with the PR 17 minutes mark (of phase 2) and i got no Berserk.

I can try it again on a fresh char if somehhow the instance after unbind all still its fucked up or smth

@TheSCREWEDSoftware TheSCREWEDSoftware added Tested This PR has been tested and is working. and removed Testing in Progress labels Nov 15, 2024
@Grimdhex
Copy link
Contributor

Something wrong with the PR 17 minutes mark (of phase 2) and i got no Berserk.

I can try it again on a fresh char if somehhow the instance after unbind all still its fucked up or smth

I see tested label, is it fine or not ?

@TheSCREWEDSoftware
Copy link
Contributor

TheSCREWEDSoftware commented Nov 15, 2024

Didn't add a comment because tested label says if working, but after using a fresh char that wasn't in the instance, she berserk at 10 minutes

@Nyeriah
Copy link
Member Author

Nyeriah commented Nov 15, 2024

image

@TheSCREWEDSoftware
Copy link
Contributor

It was working yesterday, was something my end, and i ran a 2nd time on the same PR with a fresh char she engaged at 10. So the PR is good

@Nyeriah Nyeriah merged commit 07793f6 into azerothcore:master Nov 15, 2024
13 checks passed
@Nyeriah Nyeriah deleted the dive branch November 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-cpp Used to trigger the matrix build Script Tested This PR has been tested and is working. To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[The Eye] - Boss: Al'ar goes berserk after 15 minutes [The Eye] Al'ar goes Beserk only after 15 minutes
3 participants