public.json: Adjust anyOf syntax to use schema and $ref #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I landed the previous syntax in 168a97b (public.json: Add '{GET|POST} /payment-methods' and 'GET /payment-method/{id} ' endpoints, 2015-02-11), which pointed out that anyOf isn't valid Swagger 2.0. But it's looking like the consensus is around including it in the next Swagger release [1]. The JSON Schema example I was following [2] didn't use $ref in their example, but they do use $ref in their allOf example [3]. This commit updates the existing anyOf uses to match that syntax. [1]: OAI/OpenAPI-Specification#57 (comment) [2]: http://spacetelescope.github.io/understanding-json-schema/reference/combining.html#anyof [3]: http://spacetelescope.github.io/understanding-json-schema/reference/combining.html#allof
caseybessette
added a commit
that referenced
this pull request
Oct 7, 2015
public.json: Adjust anyOf syntax to use schema and $ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I landed the previous syntax in 168a97b (public.json: Add '{GET|POST}
/payment-methods' and 'GET /payment-method/{id} ' endpoints,
2015-02-11), which pointed out that anyOf isn't valid Swagger 2.0.
But it's looking like the consensus is around including it in the next
Swagger release 1. The JSON Schema example I was following 2
didn't use $ref in their example, but they do use $ref in their allOf
example 3. This commit updates the existing anyOf uses to match
that syntax.