easter sunday and pentecost sunday are not nationwide german holidays

[TalonTR]

They are holidays only in Brandenburg, see https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland#%C3%9Cbersicht_aller_gesetzlichen_Feiertage

[stelgenhof]

Thanks for the PR!

The source for defining the German Public Holidays was mainly Wikipedia: https://en.wikipedia.org/wiki/Public_holidays_in_Germany. This page list Easter Sunday and Pentecost as celebrated in all states. Comparing it with your source, this one is then incorrect?

Cheers! Sacha

[crossan007]

I just discovered that Easter does not show up in the 'USA' provider as well.

[stelgenhof]

@crossan007 It's correct it is not included as currently the USA provider focuses on Federal Holidays only. Of course, non-federal/other holidays can be added as well :)

Cheers! Sacha

[TalonTR]

The table from your referenced english Wikipedia page doesn't list Pentecost Sunday and Easter Sunday for any German state. Below the table it states:

In addition the state of Brandenburg has formally declared Easter Sunday and Pentecost Sunday as public holidays. As these are Sundays anyway, they have been left away by the other states, nor counted in the table above (the state of Hesse even declared all Sundays public holidays)."

This is exactly the same as within the german Wikipedia.

These dates are celebrated nationwide, but are not considered holidays in most states.

[stelgenhof]

@TalonTR Perfect! I must have overlooked that.

[stelgenhof]

Can you update the unit tests respectively since the logic will change? That way we can verify if the changes work perfectly or not.

[TalonTR]

Didn't i already do that? All German Easter Sunday and Pentecost Sunday Tests are modified.

[stelgenhof]

You're right. Perfect! Can you only update the CHANGELOG.md file reflecting this fix?

[TalonTR]

Done :)