Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Japanese Emperor will abdicate the throne At May 1st 2019. #130

Merged
merged 6 commits into from
Mar 7, 2019
Merged

The Japanese Emperor will abdicate the throne At May 1st 2019. #130

merged 6 commits into from
Mar 7, 2019

Conversation

cookie-maker
Copy link
Contributor

The Japanese Emperor will abdicate the throne At May 1st 2019.
Therefore, three changes will occur.

[1st]
Change [Emperors Birthday(天皇誕生日)] to Feb 23th.So,
since 1949 to 1988 : Apr 29th,
since 1989 to 2018 : Dec 23th,
since 2020 : Feb 23th.(The Emperor will abdicate at May 1st 2019. So The Emperor Birthday is not in 2019)

[2nd]
Add [Coronation Day(即位の日)]. at May 1st only 2019.

[3rd]
Add [Enthronement Proclamation Ceremony(即位礼正殿の儀)]. at Oct 22th only 2019.

https://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html

Change Emperors Birthday to Feb 23th.
Add Coronation Day And Enthronement Proclamation Ceremony.
@stelgenhof stelgenhof added this to the v2.1.0 milestone Mar 6, 2019
@stelgenhof stelgenhof self-requested a review March 7, 2019 00:21
src/Yasumi/Provider/Japan.php Outdated Show resolved Hide resolved
tests/Japan/CoronationDayTest.php Outdated Show resolved Hide resolved
@stelgenhof stelgenhof merged commit 025843a into azuyalabs:develop Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants