-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Juneteenth with observed dates #282
Conversation
Hi @tylershuster Thanks for the PR! Can you please add some unit tests? Please see also: https://github.com/azuyalabs/yasumi/blob/develop/CONTRIBUTING.md |
Will do. Sorry about the commit history; I'll clean that up. I'm a little confused about the existing unit tests because it seems to already test for the change I added! (minus the "(observed)" portion) |
Please pardon my tardiness. Things seem to be in order, so please review. |
@tylershuster Reran the checks and there seem to be some code style issues. |
@tylershuster Can you check once more your PR as there some minor errors? I'd like to include this fix in the next release I am planning. Thanks! |
70d02f8
to
a41b68a
Compare
@stelgenhof I think the style is fine now — PHPCS doesn't throw any errors. |
a41b68a
to
4cb4413
Compare
Thanks for the feedback. I think those issues are cleaned up. I tried to pattern it after an existing substitute holiday |
Failure seems...incorrect |
The unsuccessful checks are not directly related to this PR. I will merge it and resolve these afterwards. |
No description provided.