Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New translation for Norway’s national day #98

Merged
merged 3 commits into from
May 17, 2018

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Mar 4, 2018

I believe the usual name for Norway's national day on 17 May is Grunnlovsdag (National Day) or Grunnlovsdagen (The National Day).

I don't know of any official source to quote, but here are some examples:

  • Norske helligdager by Visit Oslo (turist agency) uses grunnlovsdagen.
  • Wikipedia entry – this article uses both grunnlovsdag(en) and nasjonaldagen, but grunnlovsdag is used in the tittle.
  • 2018 calendar by timeanddate.no uses grunnlovsdag – a website published by a Norwegan company.
  • A4 calendar by Almanakkforlaget – a Norwegian company selling printed calendars.

Disclaimer: I am not a native Norwegian speaker, but being from Denmark, I can read the other Scandinavian languages. Perhaps a Norwegian can chip in here?

@stelgenhof
Copy link
Member

Hi @c960657 !

Thanks for the PR. When I added this provider for Norway I based my information on Wikipedia: https://en.wikipedia.org/wiki/Norwegian_Constitution_Day

Of course it maybe incorrect, however it says "grunnlovsdag" is less frequently used so that's why I initially used the former name. Anyway I am happy to merge your PR if "grunnlovsdag" is the better name :)

Cheers! Sacha

@c960657
Copy link
Contributor Author

c960657 commented Mar 4, 2018

Hi @stelgenhof,

We better get confirmation from a Norwegian before changing anything :-)

FWIW, the Wikipedia quote was added here and the footnote reference was added here, but the referenced web page no longer mentions the holiday name.

@stelgenhof
Copy link
Member

Thanks! If you happen to know somebody from Norway that would be great. Unfortunately I don't :(

@stelgenhof
Copy link
Member

@c960657 Can I merge this PR or are you still trying to get someone to confirm the translation? Just wanted to check :)

@c960657
Copy link
Contributor Author

c960657 commented May 14, 2018

No, sorry, don't have a Norwegian at hand :-) I suggest we just keep this issue open and wait for a Norwegian to confirm/reject the proposal, if that is okay with you.

@stelgenhof
Copy link
Member

@c960657 No worries! It may take a long time before we can find someone to verify this. I suggest the opposite: merge your request and if in the future somebody disagrees, a fix can be applied.

Personally I prefer issues not to be open long time.

@creuzerm
Copy link

We are asking which is more correct Grunnlovsdag vs Grunnlovsdagen ? Correct?

I can email a Norwegian Colleague to get clarification. It's already end of day there, so it may take me a day or two to get back with an answer.

@c960657
Copy link
Contributor Author

c960657 commented May 15, 2018

I think the question should rather be “which is more commonly used in writing in lists of holidays?”, i.e. we are not interested in something formally correct but never used in practice, and not in very informal usage either.

@creuzerm
Copy link

I asked a Norwegian and got back the following answer. I think he put it in terms that are useful for this discussion.

It is Grunnlovsdagen when referring to the specific day of May 17th

(Both are correct, but different grammatical forms - and to refer to the specific case you use Grunnlovsdagen not the general case)

@c960657
Copy link
Contributor Author

c960657 commented May 16, 2018

Grunnlovsdagen it is then :-) Thanks!

@c960657
Copy link
Contributor Author

c960657 commented May 17, 2018

Incidentally, Norway's national day is today! 🇳🇴

@stelgenhof stelgenhof added this to the v2.0.0 milestone May 17, 2018
@stelgenhof
Copy link
Member

@c960657 Can you change the target branch of this PR to 'develop' as that is the base branch? At the moment the PR is set for merge to the 'master' branch.

@c960657 c960657 changed the base branch from master to develop May 17, 2018 09:27
@c960657
Copy link
Contributor Author

c960657 commented May 17, 2018

Done :)

@stelgenhof stelgenhof merged commit ff23094 into azuyalabs:develop May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants