fixed switching between canada and US country code #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skmsd98 as the original owner has not responded to any of the requested features. I took it upon myself to update the package and add some new features in the meantime. Including your pull request. |
|
It's 2023 and issue exist still, what taking so long to close this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you switch from Canada to USA or vice versa, it will not change the country since changes are determined on the basis of dialCode which is +1 for both countries. I replaced the dialCode with isoCode which is not same for any two countries so that issue has been fixed. Please consider this pull request. Thanks!