Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeList return type #173

Closed
wants to merge 1 commit into from
Closed

NodeList return type #173

wants to merge 1 commit into from

Conversation

Generic param T was not used
@b-fuze
Copy link
Owner

b-fuze commented Jul 14, 2024

Thanks I missed that. This and #162 should close #4 and close #141

@b-fuze
Copy link
Owner

b-fuze commented Jul 14, 2024

Can you fix the the type errors? Run

deno task type-check

to see what they are. Also, make sure you run deno fmt so that the formatting isn't off

@turuslan
Copy link
Author

Sorry,
I tried running deno task type-check,
but it didn't report TS2322.

# macos
deno 1.45.2 (release, aarch64-apple-darwin)
v8 12.7.224.12
typescript 5.5.2
# docker
deno 1.45.2 (release, x86_64-unknown-linux-gnu)
v8 12.7.224.12
typescript 5.5.2

@timreichen
Copy link
Contributor

Is there any way to have this implemented soon?

@b-fuze
Copy link
Owner

b-fuze commented Aug 9, 2024

I can't commit to their branch so I can't fix the problems. @timreichen I saw that you created a PR, if you want to get your own PR merged I'm fine with closing this one

@timreichen
Copy link
Contributor

I can't commit to their branch so I can't fix the problems. @timreichen I saw that you created a PR, if you want to get your own PR merged I'm fine with closing this one

I reopened my initial PR. PTAL.

@b-fuze b-fuze closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants