Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: v8 upgrade handler #84

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix: v8 upgrade handler #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f96d88
fix: VersionMap from upgrade handler
dudong2 Jul 29, 2024
4dd371d
chore: Change return val
dudong2 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions app/upgrades/v8/upgrades.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,15 @@ func CreateUpgradeHandler(
sdkCtx := sdk.UnwrapSDKContext(ctx)
logger := sdkCtx.Logger().With("upgrade: ", UpgradeName)

var (
updatedVM module.VersionMap
err error
)

// Leave modules are as-is to avoid running InitGenesis.
logger.Debug("running module migrations ...")
if vm, err := mm.RunMigrations(ctx, configurator, vm); err != nil {
return vm, err
if updatedVM, err = mm.RunMigrations(ctx, configurator, vm); err != nil {
return updatedVM, err
}

// ibc-go vX -> v6
Expand All @@ -55,19 +60,19 @@ func CreateUpgradeHandler(
}

if err := baseapp.MigrateParams(sdkCtx, legacySubspace, consensusParamsStore); err != nil {
return vm, err
return updatedVM, err
}

// canto v8 custom
{
params, err := stakingKeeper.GetParams(ctx)
if err != nil {
return vm, err
return updatedVM, err
}
params.MinCommissionRate = MinCommissionRate
stakingKeeper.SetParams(ctx, params)
}

return vm, nil
return updatedVM, nil
}
}
Loading