Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: resolve keyring flag properly #88

Merged
merged 1 commit into from
Aug 2, 2024
Merged

bug: resolve keyring flag properly #88

merged 1 commit into from
Aug 2, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Aug 2, 2024

Description

ref. cosmos/cosmos-sdk#19060

Closes: #87

how to test

  • test command cantod tx feegrant prune --from <addr> --gas-prices 10000000000000000acanto --home <home dir> --chain-id canto_7700-1 --keyring-backend test. If no error occured, it is fixed well.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Aug 2, 2024
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 41a5889 into v8/develop Aug 2, 2024
8 checks passed
@dudong2 dudong2 deleted the patch/keyring branch August 2, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Keyring address issue causing tx failure
3 participants