Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add precompiled contract logs using cosmos event converter #22

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

jasonsong0
Copy link

@jasonsong0 jasonsong0 commented Sep 5, 2024

Description

This PR includes the conversion of Cosmos-native events into EVM events
by passing the native events and converter in PostPrecompiledProcessing


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jasonsong0 jasonsong0 marked this pull request as ready for review September 9, 2024 11:10
Copy link
Collaborator

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the lint error(G115) was fixed in another pr, so ignore it

@jasonsong0 jasonsong0 merged commit 0f22ad8 into feat/precompiled-bank-contract Sep 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants