Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launchpad-start to add cr on Sigterm error #67

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

macta
Copy link
Contributor

@macta macta commented Apr 16, 2024

When this error occurs, its hard to spot if its munged against a previous log item

When this error occurs, its hard to spot if its munged against a previous log item
@macta
Copy link
Contributor Author

macta commented Apr 16, 2024

This is to help with examples like this:
image

docker/pharo/launchpad-start Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (40dae7c) to head (ebed6f4).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-candidate      #67   +/-   ##
==================================================
  Coverage              99.78%   99.78%           
==================================================
  Files                     58       58           
  Lines                   3751     3751           
==================================================
  Hits                    3743     3743           
  Misses                     8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli
Copy link
Member

Failing tests need access to secrets not available for external PRs.

@gcotelli gcotelli merged commit 93b5bfd into ba-st:release-candidate Apr 16, 2024
32 of 34 checks passed
@macta macta deleted the patch-1 branch April 17, 2024 09:08
@macta
Copy link
Contributor Author

macta commented Apr 17, 2024

Thanks for agreeing to do this guys - by the way, when does it appear in a build so I can try it for real in my app in question?

@gcotelli
Copy link
Member

gcotelli commented Apr 17, 2024

It's already available in the release-candidate branch, so if you change your Launchpad dependency in the docker image (the FROM part) and use release-candidate instead of v5 you can test it. I will probably merge these changes to the v5 and release a new version once the dry run PR is ready and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants