Accept lists of ports #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified existing methods to work with a list of ports instead of a starting port and ending port.
Closed
| , async = require('async') | ||
| var net = require('net'); | ||
| var Socket = net.Socket; | ||
| var async = require('async'); |
There was a problem hiding this comment.
In general, I recommend sticking to the current project style when submitting pull requests. Changes like adding var or ; are just noise. And, if they were accepted, it would make this project have a mix of styles. Please remove these changes.
This reverts commit eb5a2dd.
Implemented changes suggested. Cohesive code style and backwards compatibility. New methods are named as the old method with a "inList" suffix - for instance, findAPortNotInUseInList.
|
Revised changes. |
|
Any chance for detecting arrays from the original APIs instead of adding new methods? |
Now the original API works with both arrays and start/end ports. Detection on which method to use is based on argument number.
|
Yes, now both functionalities work with the original API. |
|
Cool. If it gets a blessing from @EndangeredMassa we can close the related issue. |
|
Still waiting for an update on this. |
|
Same. If the project maintainer does not respond or merge this within the next few days, I will carve out some time to test it so we can resolve the bounty. |
|
I started reviewing. |
laggingreflex
added a commit
to laggingreflex/node-portscanner
that referenced
this pull request
Nov 18, 2016
Revert "Merge pull request baalexander#28 from darthneko/master" This reverts commit 3a271ee, reversing changes made to c2092ce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified existing methods to work with a list of ports instead of a
starting port and ending port.