Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot polyfilled on optional chains #221

Merged
merged 7 commits into from
Sep 23, 2024
Merged

fix: Cannot polyfilled on optional chains #221

merged 7 commits into from
Sep 23, 2024

Conversation

liuxingbaoyu
Copy link
Member

@nicolo-ribaudo
Copy link
Member

@liuxingbaoyu @JLHwung I added a commit to also support usage-pure, could you take a look?

@nicolo-ribaudo
Copy link
Member

Hold on, there are a few more bugs.

@nicolo-ribaudo
Copy link
Member

Ok, it should be good now :)

liuxingbaoyu
liuxingbaoyu commented Sep 20, 2024
View reviewed changes
Copy link
Member Author

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s awesome, thank you!

packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-pure/optional-chaining/output.mjs Outdated
((_context14 = a.b) == null ? void 0 : _toSortedInstanceProperty(_context14.c))?.d.e;
_Array$from(x);
_Array$from?.(x);
_Array$from?.(x).c;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Maybe we can compile to _Array$from(x)?

@nicolo-ribaudo nicolo-ribaudo merged commit bacb1df into babel:main Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: toSorted is not polyfilled on optional chains without plugin-transform-optional-chaining
3 participants
@liuxingbaoyu @nicolo-ribaudo @JLHwung